-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 0.25.0 release #10497
Prepare 0.25.0 release #10497
Conversation
releasenotes/notes/0.25/discrete-pulse-library-deprecation-3a95eba7e29d8d49.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/discrete-pulse-library-deprecation-3a95eba7e29d8d49.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/gaussian-square-echo-pulse-84306f1a02e2bb28.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/add-block-collection-options-359d5e496313acdb.yaml
Outdated
Show resolved
Hide resolved
applying this pass recursively to the blocks in control flow operations. Note that the meaning | ||
of "block" in :class:`.ConsolidateBlocks` is unrelated to that in | ||
:class:`.ControlFlowOp`. | ||
Enabled support for :class:`.ControlFlowOp` operations in the :class:`.ConsolidateBlocks` pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to say "Previously, the blocks in control flow operations were skipped by this pass." like you did for commutative cancellation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if that's true or not. Do you know off hand? I was just going off the original wording of each.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall I can check the PR. But it's fine like this. I only asked because back to back it was a noticeable difference.
releasenotes/notes/0.25/add-pauli-equivalences-74c635ec5c23ee33.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/add-pauli-equivalences-74c635ec5c23ee33.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/dag-substitute-node-propagate-condition-898052b53edb1f17.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/display-control-flow-mpl-drawer-2dbc7b57ac52d138.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/enable_target_aware_meas_map-0d8542402a74e9d8.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/faster-parameter-rebind-3c799e74456469d9.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/filter-schedule-block-29d392ca351f1fb1.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll actually help read the notes tomorrow...
One or more of the the following people are requested to review this:
|
issues: | ||
features_circuits: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general question: is this the way we plan to do this categorisation moving forwards? Seems like a lot of extra work on the release manager, whereas we could be doing it a little more on-the-fly as we merge PRs. I don't know how that interacts with how we manage our Reno configs, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fundamental issue is the subcategories feature still isn't included in a reno elease, so we're installing it from source to get the functionality. I think it adds a lot the readability of the notes, but I think forcing a source install on main is a bigger dev burden if we want people to write notes. Once it is in a release though we can start enforcing this as part of PRs I think.
releasenotes/notes/0.25/add-block-collection-options-359d5e496313acdb.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/add-feature-negativity-logarithmic-negativity-fce5d8392460a0e9.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/add-feature-negativity-logarithmic-negativity-fce5d8392460a0e9.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/gaussian-square-echo-pulse-84306f1a02e2bb28.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/pauli-rotation-equivalences-6b2449c93c042dc9.yaml
Show resolved
Hide resolved
releasenotes/notes/0.25/qasm3-no-subroutine-b69c5ed7c65ce9ac.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/relax_wire_order_restrictions-ffc0cfeacd7b8d4b.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/add-pauli-equivalences-74c635ec5c23ee33.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/deprecate-complex-amp-41381bd9722bc878.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/discrete-pulse-library-deprecation-3a95eba7e29d8d49.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM and I think we're almost ready to merge and tag the release. I left a couple last comments inline. There is one more PR in the backport queue that has new release notes that there was some discussion on improving in the main
branch PR here: #10503 that we'll need to update here after it merges.
applying this pass recursively to the blocks in control flow operations. Note that the meaning | ||
of "block" in :class:`.ConsolidateBlocks` is unrelated to that in | ||
:class:`.ControlFlowOp`. | ||
Enabled support for :class:`.ControlFlowOp` operations in the :class:`.ConsolidateBlocks` pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall I can check the PR. But it's fine like this. I only asked because back to back it was a noticeable difference.
releasenotes/notes/0.25/deprecate-instruction-qasm-9380f721e7bdaf6b.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/fix-delay-padding-75937bda37ebc3fd.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/0.25/preset-pm-vf2-max-trials-958bb8a36fff472f.yaml
Outdated
Show resolved
Hide resolved
prelude: | | ||
The Qiskit Terra 0.25.0 release highlights are: | ||
|
||
* Control-flow operations are now supported through the transpiler at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just copies of the release notes in the feature section right? Maybe we either want to have a more brief entry that just highlights the feature for the prelude, or if we're going to keep the full notes here we should remove the corresponding feature note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah they're the same. IMO, it's important for these to be up top since it might help with adoption (at least in the case of the classical expression support), and I like the complete form for that. I don't mind these appearing twice, especially since subsequent entries from the same release note file will appear right after them in the corresponding sections below. I don't mind changing this though if you feel strongly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, lets go with this then. We haven't done this in the past, but lets give this a try and see how it works out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all the hard work updating everything and preparing the final release.
Summary
This commit prepares the 0.25.0 release, this involves 3 steps:
As we did in 0.24, we're using a pre-release feature in reno to add subsections to the release notes. Subsections are added to the features, deprecations, and upgrade sections for:
I've also added the following new sections:
Details and comments
TODO: