-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the ergonomics of the TranspileLayout class #10835
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d423924
Improve the ergonomics of the TranspileLayout class
mtreinish cf0117d
Handle None for the private TranspileLayout fields in QPY
mtreinish 2e1af45
Merge branch 'main' into imrpove-transpile-layout
mtreinish 8546928
Add test for full_layout with ancillas
mtreinish 3f2542b
Rework interface to be more consistent
mtreinish 638fa91
Merge branch 'main' into imrpove-transpile-layout
mtreinish a72b510
Apply suggestions from code review
mtreinish 2a9dc29
Merge branch 'main' into imrpove-transpile-layout
mtreinish abccd99
Merge remote-tracking branch 'origin/main' into imrpove-transpile-layout
mtreinish 61a087d
Remove permute_sparse_pauli_op()
mtreinish 2286a1b
Update docs
mtreinish 3ab8cea
Fix docs build post-rebase
mtreinish aace5aa
Merge remote-tracking branch 'origin/main' into imrpove-transpile-layout
mtreinish 5acc2c0
Fix docs issues
mtreinish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this
struct
format string doesn't match the definition of the C struct up top -exists
is achar
in the C definition and_Bool
here - but in practice it would be pretty wild to have a system where_Bool
wasn't ABI compatible withchar
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I probably just copy and pasted both from V1 as this doesn't change between V1 and V2. IIRC we added this discrepancy between docs and the
struct
format string as part of your review in #10148: #10148 (comment) . I can update it to be_Bool
in the docs if you prefer though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, it's fine, let's just leave it.