Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect stop time bug #8729 #11097

Merged
merged 7 commits into from
Feb 13, 2025
Merged

Fix incorrect stop time bug #8729 #11097

merged 7 commits into from
Feb 13, 2025

Conversation

JustinWoodring
Copy link
Contributor

@JustinWoodring JustinWoodring commented Oct 24, 2023 •
edited
Loading

  • I have added the tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Summary

This pull request addresses the incorrect stop time bug related in #8729. I have also added tests to ensure this change doesn't break again.

Fixes #8729.

@JustinWoodring JustinWoodring requested a review from a team as a code owner October 24, 2023 04:20
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Oct 24, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@JustinWoodring JustinWoodring mentioned this pull request Oct 24, 2023
Closed
itoko
itoko previously approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@itoko itoko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will fix the bug in qubit_duration, which uses qubit_stop internally as well. Thank you so much and sorry for my too late response.

@coveralls
Copy link

coveralls commented Jan 30, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13063268479

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.809%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/circuit/quantumcircuit.py 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 92.97%
crates/qasm2/src/lex.rs 5 91.73%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 13055798857: -0.02%
Covered Lines: 79758
Relevant Lines: 89808
💛 - Coveralls

itoko
itoko reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@itoko itoko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor update on the release note

@itoko
Apply suggestions from code review
8a0fdff 
Minor update on the release note
itoko
itoko previously approved these changes Jan 30, 2025
View reviewed changes
@itoko
Copy link
Contributor

itoko commented Jan 31, 2025

@Qiskit/terra-core Can someone please approve this?

@itoko itoko enabled auto-merge January 31, 2025 11:58
@1ucian0 1ucian0 added Changelog: Bugfix Include in the "Fixed" section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable labels Feb 13, 2025
1ucian0
1ucian0 reviewed Feb 13, 2025
View reviewed changes
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Qiskit dev community @JustinWoodring

The fix looks good to me, thanks! I just left two unimportant comments for you to consider. All non-blocking, so let me know what do you think.

@1ucian0 1ucian0 self-assigned this Feb 13, 2025
@1ucian0 1ucian0 added this to the 1.3.3 milestone Feb 13, 2025
@1ucian0
Copy link
Member

1ucian0 commented Feb 13, 2025

Gosh.. I just realized this is from Oct 2023 :-/. Maybe @itoko can consider my suggestions? Otherwise, we merge as it is.

@itoko @1ucian0
Update qiskit/circuit/quantumcircuit.py
609af3f 
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
@itoko @1ucian0
Update releasenotes/notes/fix-incorrect-qubit-stop-time-d0e056f60a01d…
49fbabd 
…d52.yaml

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
@itoko itoko added this pull request to the merge queue Feb 13, 2025
@1ucian0
Copy link
Member

1ucian0 commented Feb 13, 2025

Thanks @itoko !

@JustinWoodring
Copy link
Contributor Author

🥳

Merged via the queue into Qiskit:main with commit 6842268 Feb 13, 2025
16 of 17 checks passed
mergify bot pushed a commit that referenced this pull request Feb 13, 2025
@JustinWoodring @mergify
Fix incorrect stop time bug #8729 (#11097)
bd2e488 
* Fix incorrect stop time bug #8729

* Apply suggestions from code review

Minor update on the release note

* Update qiskit/circuit/quantumcircuit.py

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

* Update releasenotes/notes/fix-incorrect-qubit-stop-time-d0e056f60a01dd52.yaml

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

---------

Co-authored-by: Toshinari Itoko <15028342+itoko@users.noreply.github.com>
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
(cherry picked from commit 6842268)
@mergify mergify bot mentioned this pull request Feb 13, 2025
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this pull request Feb 14, 2025
@mergify @JustinWoodring
Fix incorrect stop time bug #8729 (#11097) (#13843)
acc9cec 
* Fix incorrect stop time bug #8729

* Apply suggestions from code review

Minor update on the release note

* Update qiskit/circuit/quantumcircuit.py

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

* Update releasenotes/notes/fix-incorrect-qubit-stop-time-d0e056f60a01dd52.yaml

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

---------

Co-authored-by: Toshinari Itoko <15028342+itoko@users.noreply.github.com>
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
(cherry picked from commit 6842268)

Co-authored-by: Justin Woodring <jwoodrg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ucian0 1ucian0 1ucian0 approved these changes

@itoko itoko itoko left review comments

Assignees

@1ucian0 1ucian0

Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
Contributor Monitoring
Status: Done
Milestone
1.3.3
Development

Successfully merging this pull request may close these issues.

Qubit stop time
5 participants
@JustinWoodring @qiskit-bot @coveralls @itoko @1ucian0