Add constructor methods to build QuantumCircuits from QASM #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
nonhermitian and
taalexander
as code owners
|
can we get some tests and update the example also i would depreciate the wrapper functions that use load_from_file and load_from_string |
|
Sure, I'll add some tests for this and deprecate the wrapper methods |
mtreinish
force-pushed
the
add-qasm-constructor
branch
from
8e98b4d to
c71d007
Compare
This was referenced Oct 31, 2018
|
this looks good. Its just failing in the linter. |
|
sigh, it's failing on tempfile in appveyor just like @nonhermitian PR. I guess I'll do the same skip on the tests here too |
mtreinish
force-pushed
the
add-qasm-constructor
branch
from
4543160 to
5a36392
Compare
jaygambetta
previously approved these changes
Nov 2, 2018
|
@mtreinish can you fix the conflicts with @ajavadia addition and then we should merge |
This commit adds 2 new static methods to the QuantumCircuit class to enable constructing a QuantumCircuit from a QASM string or file. This gives users to option of building a QuantumCircuit object with a qasm file simply by calling: circuit = QuantumCircuit.from_qasm_file(path) or circuit = QuantumCircuit.from_qasm_str(qasm_str) As part of this change the circuitbackend imports for Unroller() had to be updated to be module imports. This was to avoid having a circular import with the _quantumcircuit module (now that _quantumcircuit leverages uses it). Fixes Qiskit#971
This commit deprecates the qasm loading functions from the wrapper module. Now that we have top level static constructor methods off the quantum circuit class these aren't needed anymore.
This commit adds unit test coverage for the new from_qasm_str() and from_qasm_file() constructor methods on the QuantumCircuit class.
mtreinish
force-pushed
the
add-qasm-constructor
branch
from
d844c55 to
b48e186
Compare
jaygambetta
approved these changes
Nov 2, 2018
jaygambetta
approved these changes
Nov 2, 2018
1ucian0
reviewed
Nov 2, 2018
1ucian0
approved these changes
Nov 2, 2018
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Add constructor methods to build QuantumCircuits from QASM This commit adds 2 new static methods to the QuantumCircuit class to enable constructing a QuantumCircuit from a QASM string or file. This gives users to option of building a QuantumCircuit object with a qasm file simply by calling: circuit = QuantumCircuit.from_qasm_file(path) or circuit = QuantumCircuit.from_qasm_str(qasm_str) As part of this change the circuitbackend imports for Unroller() had to be updated to be module imports. This was to avoid having a circular import with the _quantumcircuit module (now that _quantumcircuit leverages uses it). Fixes Qiskit#971 * Disable cyclic import pylint * Deprecate qasm loading functions in wrapper This commit deprecates the qasm loading functions from the wrapper module. Now that we have top level static constructor methods off the quantum circuit class these aren't needed anymore. * Add tests for new from_qasm*() QuantumCircuit methods This commit adds unit test coverage for the new from_qasm_str() and from_qasm_file() constructor methods on the QuantumCircuit class. * Fix pylint nitpicks * Add skip for appveyor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds 2 new static methods to the QuantumCircuit class to
enable constructing a QuantumCircuit from a QASM string or file. This
gives users to option of building a QuantumCircuit object with a qasm
file simply by calling:
circuit = QuantumCircuit.from_qasm_file(path)
or
circuit = QuantumCircuit.from_qasm_str(qasm_str)
Details and comments
As part of this change the circuitbackend imports for Unroller() had to
be updated to be module imports. This was to avoid having a circular
import with the _quantumcircuit module (now that _quantumcircuit
leverages uses it).
Fixes #971