Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad header in 0.46 release note #11803

Closed
wants to merge 1 commit into from

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Feb 14, 2024

Closes #11836. As explained there, the problem is from Sphinx rather than our API generation script. It's using a <dl> in HTML where it should not be.

After, the list works properly:

Screenshot 2024-02-14 at 6 08 47 PM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7908177852

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 89.232%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 91.44%
Totals Coverage Status
Change from base Build 7907826474: 0.03%
Covered Lines: 58847
Relevant Lines: 65948

💛 - Coveralls

@Eric-Arellano Eric-Arellano changed the title [wip] Fix bad header in 0.46 release note Fix bad header in 0.46 release note Feb 14, 2024
@Eric-Arellano Eric-Arellano marked this pull request as ready for review February 14, 2024 23:34
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@Eric-Arellano
Copy link
Collaborator Author

This is ready for review and would be good to include in the 1.0 release. I'm not sure if it should be included directly in #11760?

@Eric-Arellano Eric-Arellano added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Feb 14, 2024
@Eric-Arellano Eric-Arellano added this to the 1.0.0 milestone Feb 14, 2024
@jakelishman
Copy link
Member

At this point, it's probably best just to do it with the rest of the release notes. I've applied this patch to #11760 in 476c945, so I'll close this PR - thanks for pointing it out.

@Eric-Arellano Eric-Arellano deleted the fix-46-release-note branch February 15, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird header from bullet list for 0.46 release notes
4 participants