Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EstimatorV2Converter and BackendEstimatorV2 #11899

Closed
wants to merge 5 commits into from

Conversation

ikkoham
Copy link
Contributor

@ikkoham ikkoham commented Feb 27, 2024

Summary

Add EstimatorV2Converter and BackendEstimatorV2 to qiskit.primitives.
EstimatorV2Converter converts an instance of BaseEstimatorV1 into an instance
of BaseEstimatorV2. BackendEstimatorV2 is simple conversion of BackendEstimator
that inherits BaseEstimatorV1.

@ikkoham ikkoham added Changelog: New Feature Include in the "Added" section of the changelog mod: primitives Related to the Primitives module labels Feb 27, 2024
@ikkoham ikkoham added this to the 1.1.0 milestone Feb 27, 2024
@coveralls
Copy link

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 8098602282

Details

  • 69 of 73 (94.52%) changed or added relevant lines in 3 files are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.007%) to 89.296%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/primitives/backend_estimator.py 21 25 84.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 91.44%
crates/qasm2/src/parse.rs 12 96.69%
Totals Coverage Status
Change from base Build 8097968633: 0.007%
Covered Lines: 59180
Relevant Lines: 66274

💛 - Coveralls

@ikkoham ikkoham changed the title [WIP] Add EstimatorV2Converter [WIP] Add EstimatorV2Converter and BackendEstimatorV2 Feb 28, 2024
@ikkoham ikkoham changed the title [WIP] Add EstimatorV2Converter and BackendEstimatorV2 Add EstimatorV2Converter and BackendEstimatorV2 Feb 29, 2024
@ikkoham ikkoham marked this pull request as ready for review February 29, 2024 16:10
@ikkoham ikkoham requested review from a team as code owners February 29, 2024 16:10
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ajavadia
  • @ikkoham
  • @levbishop
  • @t-imamichi

@1ucian0
Copy link
Member

1ucian0 commented Mar 19, 2024

Should this PR be updated after #11931 merged ?

@t-imamichi
Copy link
Member

t-imamichi commented Mar 19, 2024

This PR currently includes 1) a converter from EstimatorV1 to Estimator V2 and 2) a backend Estimator V2.
The second one was already addressed by #11931. So, we need to discuss whether we want to merge a converter 1).

  • Pros: it might be useful if only Estimator V1 is available, e.g., AerEstimator.
  • Cons: we need to maintain the converter.

The discussion may depend on how many Estimator V1 implementations available.

@1ucian0
Copy link
Member

1ucian0 commented Mar 20, 2024

In discussion with others in the core team about the EstimatorV1-to-EstimatorV2 converter (and general PrimitiveV1-to-PrimitiveV2):

  • There is value in this kind of converters for users and primitives implementors
  • Aer should natively implement primitives in the long run, without converters
  • Converters from PrimitivesV1 should live until PrimitivesV1 gets removed

Let's close this PR and move this conversation to issues for primitive converters: #12047 #12046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: primitives Related to the Primitives module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants