Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.46.1 #11969

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Prepare 0.46.1 #11969

merged 3 commits into from
Mar 8, 2024

Conversation

kevinhartman
Copy link
Contributor

Summary

Details and comments

@kevinhartman kevinhartman requested a review from a team as a code owner March 7, 2024 22:06
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

@1ucian0
Copy link
Member

1ucian0 commented Mar 8, 2024

There seems to be a flaky test failing that blocked this merged. Therefore:

@kevinhartman
Copy link
Contributor Author

After a bit more investigation, @jakelishman and I have found that the CI failure hit in Windows is actually reproducible on all platforms, but is not introduced in this release (it currently exists in both 0.46.0 as well as the newly released 1.0.2 for example).

Given that it's not newly introduced and hasn't been hit until now, we'll continue with 0.46.1 as is.

(I'll create a bug and cross-reference this PR)

@kevinhartman kevinhartman added this pull request to the merge queue Mar 8, 2024
Merged via the queue into Qiskit:stable/0.46 with commit e43d5f1 Mar 8, 2024
11 of 12 checks passed
@jakelishman
Copy link
Member

The above bug was a manifestation of #11975 - in certain cases, the test in question (test.python.compiler.test_transpiler.TestMultiChipXXXX.test_transpile_target_with_qubits_without_ops_with_routing at optimization_level=3) would have a swap in its chosen layout+routing, and the target had single-direction CXs, so we'd end up calling GateDirection to flip two of the CXs with Hadamards, then the whole block would be 4 CXs, so attempt to be collected.

As of 0.46.1 and 1.0.2, the following block and seed reproduces that failure reliably:

from qiskit import transpile, QuantumCircuit
from qiskit.circuit import library
from qiskit.transpiler import Target, InstructionProperties
target = Target(num_qubits=5)
target.add_instruction(library.XGate(), {(i,): InstructionProperties(error=0.5) for i in range(4)})
target.add_instruction(library.HGate(), {(i,): InstructionProperties(error=0.5) for i in range(4)})
target.add_instruction(
    library.CXGate(),
    {edge: InstructionProperties(error=0.5) for edge in [(0, 1), (1, 2), (2, 0), (2, 3)]},
)
qc = QuantumCircuit(4)
qc.x(0)
qc.cx(0, 1)
qc.cx(0, 2)
qc.cx(1, 3)
qc.cx(0, 3)

transpile(qc, target=target, optimization_level=3, seed_transpiler=57783)

@eliarbel eliarbel added this to the 0.46.1 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants