Only use rust two qubit weyl coordinates functions #11982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a follow up to Qiskit#11019 that uses the rust implementation of computing the weyl coordinates for a unitary and the transform_to_magic_basis functions everywhere. Previously they were only used internally by the num_basis_gates() rust function to estimate the number of basis gates needed for a decomposition of a given unitary. This will likely be superseded by Qiskit#11946 when that is working, but this is mainly an incremental step working towards finishin Qiskit#11946 that proves the internal rust functions work in the larger decomposer code to isolate the source of failures in Qiskit#11946.
mtreinish
added
performance
Changelog: None
mtreinish
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 8227852660Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit is a follow up to #11019 that uses the rust implementation of computing the weyl coordinates for a unitary and the transform_to_magic_basis functions everywhere. Previously they were only used internally by the num_basis_gates() rust function to estimate the number of basis gates needed for a decomposition of a given unitary. This will likely be superseded by #11946 when that is working, but this is mainly an incremental step working towards finishing #11946 that proves the internal rust functions work in the larger decomposer code to isolate the source of failures in #11946.
Details and comments