Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pulp from 0.18.9 to 0.18.10 #12182

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 15, 2024

Bumps pulp from 0.18.9 to 0.18.10.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [pulp](https://github.com/sarah-ek/pulp) from 0.18.9 to 0.18.10.
- [Commits](https://github.com/sarah-ek/pulp/commits)

---
updated-dependencies:
- dependency-name: pulp
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner April 15, 2024 11:13
@dependabot dependabot bot added Changelog: None Do not include in changelog dependencies Pull requests that update a dependency file Rust This PR or issue is related to Rust code in the repository labels Apr 15, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8688115877

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 89.341%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 92.62%
Totals Coverage Status
Change from base Build 8686173229: 0.002%
Covered Lines: 60155
Relevant Lines: 67332

💛 - Coveralls

@jakelishman
Copy link
Member

This bumps bytemuck to 1.15 in order to use the aarch64_simd feature, which bytemuck explicitly says it will make no MSRV promises about. We probably need to attempt an AArch64 build with rustc stable to verify before merging this.

@mtreinish
Copy link
Member

We can test it with #12102 if needed. That will at least work as a build test even if we're having issues with numpy in the unit tests. That being said I think it should be fine, it looks like the msrv is 1.59 with that feature:

https://github.com/Lokathor/bytemuck/blob/v1.15.0/Cargo.toml#L33

and in the code it just enables a bunch of use of arm neon intrinsics from their stdlib definitions.

@jakelishman
Copy link
Member

Ah nice, I didn't actually get as far as looking for hints in the source code. Let's merge and let #12102 handle the testing then - can always revert if needed.

@jakelishman jakelishman added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 9422492 Apr 15, 2024
14 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/pulp-0.18.10 branch April 15, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog dependencies Pull requests that update a dependency file Rust This PR or issue is related to Rust code in the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants