Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for removing non-ascii-name #12198

Merged

Conversation

joesho112358
Copy link
Contributor

@joesho112358 joesho112358 commented Apr 18, 2024

Summary

Part of the effort in #9614 to incrementally remove lints

Details and comments

Only used for 3 variables in 1 file. If those variables are preferred, then we can close this and I can create a new PR to move it above the decision line.

Also, open to renaming lambda_p and such :|

@joesho112358 joesho112358 requested a review from a team as a code owner April 18, 2024 02:49
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Apr 18, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Apr 18, 2024

Pull Request Test Coverage Report for Build 8731920963

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.009%) to 89.26%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.6%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 8728514558: -0.009%
Covered Lines: 60305
Relevant Lines: 67561

💛 - Coveralls

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at these lints! I'm fine with lambda_p and friends in the test file to avoid the naming conflict - it's just one test file, and just using Greek letters (whether the letter or the name) is lazy-scientist naming on our part already, so no worries.

@jakelishman jakelishman added this pull request to the merge queue Apr 18, 2024
@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Apr 18, 2024
@jakelishman jakelishman added this to the 1.1.0 milestone Apr 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 18, 2024
@jakelishman jakelishman added this pull request to the merge queue Apr 18, 2024
Merged via the queue into Qiskit:main with commit 9ede1b6 Apr 18, 2024
12 checks passed
@joesho112358 joesho112358 deleted the remove-no-ascii-name-lint-exclusion branch April 18, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo type: qa Issues and PRs that relate to testing and code quality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants