Removing lint rules that are unused

[joesho112358]

Summary

#9614 removing some of the rules that currently do not result in an error

Details and comments

Removing
unknown-option-value
unnecessary-direct-lambda-call
unnecessary-ellipsis
use-list-literal
because they do not appear to currently trigger. Figure they can be looked at again if they ever do cause an issue. Otherwise, I can close this and push them above for long term removal.

It does appear that use-list-literal vs use-dict-literal is inconsistent:

qiskit/test/python/result/test_result.py

Lines 59 to 61 in ff7ba3f

	data = models.ExperimentResultData(counts=dict(**raw_counts))
	exp_result = models.ExperimentResult(shots=14, success=True, meas_level=2, data=data)
	result = Result(results=[exp_result], **self.base_result_args)

Line 59 defines a dictionary with dict(...) and line 61 defines a list with [...]

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Qiskit/terra-core

[jakelishman]

Thanks!

That discrepancy you highlighted in dict(**mapping) was likely overzealous find-and-replace than a particular intention to use the dict constructor. The Result code used to use a very heavy validation library that made everything into objects with expensive schemas backing it, so there was loads of stuff like RandomObject(**deserialised) to try and stuff data back into the validators. Some of those just became raw dict instances, so we probably accidentally ended up with this funny dict(**dict) stuff, which at the time there was no lint against.

[coveralls]

Pull Request Test Coverage Report for Build 8747199799

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 11 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.02%) to 89.274%

---

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/lex.rs	5	92.37%
crates/qasm2/src/parse.rs	6	97.61%

Totals
Change from base Build 8745563164:	0.02%
Covered Lines:	60320
Relevant Lines:	67567

---

💛 - Coveralls