Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing modified-iterating-list from lint exclusions and updates #12294

Merged

Conversation

joesho112358
Copy link
Contributor

@joesho112358 joesho112358 commented Apr 24, 2024

Summary

#9614 test for removing modified-iterating-list

Details and comments

Updated the single rule break

@joesho112358 joesho112358 requested a review from a team as a code owner April 24, 2024 03:12
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Apr 24, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8810457634

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 28 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 89.446%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 92.37%
crates/qasm2/src/parse.rs 24 96.23%
Totals Coverage Status
Change from base Build 8807324183: -0.03%
Covered Lines: 60340
Relevant Lines: 67460

💛 - Coveralls

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - if nothing else, for highly commutative graphs this is potentially a performance improvement too.

@jakelishman jakelishman added this pull request to the merge queue Apr 24, 2024
@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Apr 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2024
@jakelishman jakelishman added this pull request to the merge queue Apr 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2024
@jakelishman jakelishman added this pull request to the merge queue Apr 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2024
@jakelishman jakelishman added this pull request to the merge queue Apr 24, 2024
Merged via the queue into Qiskit:main with commit 3fe2e23 Apr 24, 2024
12 checks passed
@joesho112358 joesho112358 deleted the remove-modified-iterating-list-lint-rule branch April 25, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo type: qa Issues and PRs that relate to testing and code quality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants