Removing nested-min-max from lint exclusions and updates #12295
Conversation
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
| size = max(max(layout_mapping), max(layout_mapping.values())) | ||
| size = max(layout_mapping, layout_mapping.values()) |
There was a problem hiding this comment.
These don't quite mean the same thing - max in one-argument form consumes the iterable and with two-or-more arguments it returns the max argument without iterating any individual argument.
If pylint is suggesting this, it's a bug, because they're not the same thing. (If it is a bug, there's a good chance it's fixed on pylint main - we're not using the newest version.)
There was a problem hiding this comment.
Righto! Looks like this will need to be closed and the nested-min-max should be moved up to permanent with a note. I can do that later on. Thanks for the look!
|
This looks to be necessary and will need a new PR for commenting why |
Summary
#9614 test for removing
nested-min-maxDetails and comments
Flattening nested
max's