Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve docstring of plot_circuit_layout #12370

Merged
merged 2 commits into from
May 9, 2024
Merged

improve docstring of plot_circuit_layout #12370

merged 2 commits into from
May 9, 2024

Conversation

kevinsung
Copy link
Contributor

Summary

Fixes #12334

Details and comments

@kevinsung kevinsung requested review from nonhermitian and a team as code owners May 8, 2024 12:08
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented May 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9019977876

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 89.614%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 3 88.02%
qiskit/quantum_info/states/stabilizerstate.py 3 93.49%
crates/qasm2/src/lex.rs 6 92.37%
crates/qasm2/src/parse.rs 12 96.23%
Totals Coverage Status
Change from base Build 8999743027: -0.02%
Covered Lines: 62185
Relevant Lines: 69392
💛 - Coveralls

@mtreinish mtreinish added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels May 8, 2024
@mtreinish mtreinish added this to the 1.1.0 milestone May 8, 2024
Eric-Arellano
Eric-Arellano previously approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in Sphinx:

Screenshot 2024-05-09 at 10 06 42 AM

@kevinsung kevinsung enabled auto-merge May 9, 2024 14:33
@kevinsung kevinsung added this pull request to the merge queue May 9, 2024
Merged via the queue into Qiskit:main with commit 70b36d0 May 9, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request May 9, 2024
@kevinsung @mergify
improve docstring of plot_circuit_layout (#12370)
becfe50 
* improve docstring of plot_circuit_layout

* "name" -> "index"

(cherry picked from commit 70b36d0)
@mergify mergify bot mentioned this pull request May 9, 2024
Merged
@kevinsung kevinsung deleted the doc-plot-circuit-layout branch May 9, 2024 17:32
github-merge-queue bot pushed a commit that referenced this pull request May 9, 2024
@mergify @kevinsung
improve docstring of plot_circuit_layout (#12370) (#12378)
8c56f6f 
* improve docstring of plot_circuit_layout

* "name" -> "index"

(cherry picked from commit 70b36d0)

Co-authored-by: Kevin J. Sung <kevjsung@umich.edu>
ElePT pushed a commit to ElePT/qiskit that referenced this pull request May 31, 2024
@kevinsung @ElePT
improve docstring of plot_circuit_layout (Qiskit#12370)
ee91772 
* improve docstring of plot_circuit_layout

* "name" -> "index"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

@Eric-Arellano Eric-Arellano Eric-Arellano left review comments

@nonhermitian nonhermitian Awaiting requested review from nonhermitian nonhermitian is a code owner

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Improve docstring of plot_circuit_layout
5 participants
@kevinsung @qiskit-bot @coveralls @mtreinish @Eric-Arellano