[WIP] Switch to using tox in the CI environment #1238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
nonhermitian and
taalexander
as code owners
|
I'm really looking forward to combining this with #1056 which will make our CI environment basically be a single command with a few env variables set, and we can greatly simplify the travis yaml |
mtreinish
force-pushed
the
use-tox-for-ci
branch
from
bf43cf0 to
a70ba78
Compare
mtreinish
changed the title
mtreinish
force-pushed
the
use-tox-for-ci
branch
from
a70ba78 to
d28dcaf
Compare
|
Labelling as on hold until after 0.7, as part of the CI discussion. |
mtreinish
force-pushed
the
use-tox-for-ci
branch
2 times, most recently
from
283ed8b to
9ea4a75
Compare
This commit switches us to using tox to run tests in the CI environment. This simplifies our CI environment by first enabling reproducing an environment exactly like CI locally. The tox command run locally will do the same thing as CI including setting up an isolated venv for testing.
mtreinish
force-pushed
the
use-tox-for-ci
branch
from
9ea4a75 to
da9f1ff
Compare
|
0.7 is out. Let's remove this from |
1ucian0
added
type: qa
|
Since the main argument seems to be the display benefits, we agreed on discuss them in a separate issue , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit switches us to using tox to run tests in the CI environment.
This simplifies our CI environment by first enabling reproducing an
environment exactly like CI locally. The tox command run locally will do
the same thing as CI including setting up an isolated venv for testing.
As part of this the documentation is updated to show how to use tox
instead of the make test target.
Details and comments