Fix C3SXGate to_matrix method
#12742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
jakelishman
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Thanks for the catch. Looking (very briefly) at #10296, it seems like the array was always missing, even before the decorator.
| @@ -591,7 +593,7 @@ def __init__( | |||
| unit="dt", | |||
| _base_label=None, | |||
| ): | |||
| """Create a new 3-qubit controlled sqrt-X gate. | |||
| """Create a new 3-qubit contƒCrolled sqrt-X gate. | |||
There was a problem hiding this comment.
when I switch keyboards option and command are reversed and stuff happens XD
| --- | ||
| fixes: | ||
| - | | ||
| Fixed a missing decorator in :class:`.C3SXGate` that made it fail if `gate.to_matrix()` was called. |
There was a problem hiding this comment.
You can link :meth:`.Gate.to_matrix` to get the proper cross-ref.
ElePT
commented
Jul 9, 2024
Pull Request Test Coverage Report for Build 9854198448Details
💛 - Coveralls |
jakelishman
approved these changes
Jul 9, 2024
|
@Mergifyio backport stable/0.46 stable/1.1 |
✅ Backports have been created
|
This was referenced Jul 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Fix `C3SXGate` `to_matrix` method (#12742) * Fix c3sx matrix * Apply Jake's suggestion (cherry picked from commit d86f995) # Conflicts: # test/python/circuit/test_rust_equivalence.py * Remove rust test --------- Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> Co-authored-by: Elena Peña Tapia <epenatap@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Fix `C3SXGate` `to_matrix` method (#12742) * Fix c3sx matrix * Apply Jake's suggestion (cherry picked from commit d86f995) # Conflicts: # test/python/circuit/test_rust_equivalence.py * Remove rust test --------- Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> Co-authored-by: Elena Peña Tapia <epenatap@gmail.com>
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
with_controlled_gate_arraydecorator missing inC3SXGatethat enables theto_matrixmethod. This bug was found while portingC3SXGateto Rust (#12659).Details and comments
I have also noticed that the path of
C3SXGateis incorrect. It's currently inqiskit/circuit/library/standard_gates/x.pywhile it should be inqiskit/circuit/library/standard_gates/sx.py. I did not address this issue in the current PR because I believe the move to the correct location is a breaking change and should probably be left for 2.0 (although most users won't import gates directly from the file).