Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port synth_permutation_depth_lnn_kms to Rust #12746

Merged
merged 11 commits into from
Jul 22, 2024
Merged

Port synth_permutation_depth_lnn_kms to Rust #12746

merged 11 commits into from
Jul 22, 2024

Conversation

Procatv
Copy link
Contributor

@Procatv Procatv commented Jul 9, 2024 •
edited
Loading

Summary

Porting synth_permutation_depth_lnn_kms to Rust

Details and comments

Fixes #12224

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jul 9, 2024
alexanderivrii
alexanderivrii requested changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@alexanderivrii alexanderivrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for doing this! The code already looks great, but I believe you have somewhat over-simplified the construction (and this is why some the correctness tests fail).

@Procatv Procatv requested a review from alexanderivrii July 11, 2024 00:05
raynelfss
raynelfss requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@raynelfss raynelfss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, thank you for working on this! I just have a comment about the create_swap_layer function here.

crates/accelerate/src/synthesis/permutation/utils.rs Outdated Show resolved Hide resolved
crates/accelerate/src/synthesis/permutation/utils.rs Outdated Show resolved Hide resolved
@Procatv Procatv marked this pull request as ready for review July 18, 2024 20:13
@Procatv Procatv requested review from ShellyGarion and a team as code owners July 18, 2024 20:13
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @kevinhartman
  • @mtreinish

@coveralls
Copy link

coveralls commented Jul 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10009842456

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 41 of 41 (100.0%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 89.925%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 1 92.62%
qiskit/synthesis/clifford/clifford_decompose_ag.py 2 96.15%
qiskit/primitives/backend_estimator_v2.py 3 98.29%
Totals Coverage Status
Change from base Build 9992274403: 0.04%
Covered Lines: 65836
Relevant Lines: 73212
💛 - Coveralls

@ShellyGarion ShellyGarion added Rust This PR or issue is related to Rust code in the repository synthesis performance and removed Community PR PRs from contributors that are not 'members' of the Qiskit repo labels Jul 19, 2024
alexanderivrii
alexanderivrii reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@alexanderivrii alexanderivrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I only had some really-really minor nitpicks. This PR was almost ready for the past week, but for some reason was not tagged for 1.2, but I think we should include it.

crates/accelerate/src/synthesis/permutation/mod.rs Show resolved Hide resolved
crates/accelerate/src/synthesis/permutation/utils.rs Outdated Show resolved Hide resolved
crates/accelerate/src/synthesis/permutation/utils.rs Outdated Show resolved Hide resolved
crates/accelerate/src/synthesis/permutation/mod.rs Outdated Show resolved Hide resolved
@alexanderivrii alexanderivrii added this to the 1.2.0 milestone Jul 19, 2024
@raynelfss raynelfss added the Intern PR PR submitted by IBM Quantum interns label Jul 19, 2024
@Procatv Procatv requested a review from alexanderivrii July 19, 2024 18:11
alexanderivrii
alexanderivrii approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@alexanderivrii alexanderivrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@alexanderivrii alexanderivrii requested a review from raynelfss July 21, 2024 09:41
@alexanderivrii
Copy link
Contributor

This is good to go on my part. The system does not allow me to merge it before @raynelfss approves it as well (since there are requested changes, which I believe have all been addressed).

raynelfss
raynelfss approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@raynelfss raynelfss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for working on this!

@raynelfss raynelfss added this pull request to the merge queue Jul 22, 2024
Merged via the queue into Qiskit:main with commit cbf7868 Jul 22, 2024
15 checks passed
ElePT pushed a commit to mtreinish/qiskit-core that referenced this pull request Jul 24, 2024
@Procatv @ElePT
Port synth_permutation_depth_lnn_kms to Rust (Qiskit#12746)
447e84b 
* added functionality for porting

* updated functionality

* formatting

* lint changes

* resolved error

* updated docstring

* formatting

* formatting
@ElePT ElePT added Changelog: None Do not include in changelog Changelog: New Feature Include in the "Added" section of the changelog and removed Changelog: None Do not include in changelog labels Jul 30, 2024
Procatv added a commit to Procatv/qiskit-terra-catherines that referenced this pull request Aug 1, 2024
@Procatv
Port synth_permutation_depth_lnn_kms to Rust (Qiskit#12746)
74dfc71 
* added functionality for porting

* updated functionality

* formatting

* lint changes

* resolved error

* updated docstring

* formatting

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raynelfss raynelfss raynelfss approved these changes

@ShellyGarion ShellyGarion ShellyGarion approved these changes

@alexanderivrii alexanderivrii alexanderivrii approved these changes

Assignees
No one assigned
Labels
Changelog: New Feature Include in the "Added" section of the changelog Intern PR PR submitted by IBM Quantum interns performance Rust This PR or issue is related to Rust code in the repository synthesis
Projects
Contributor Monitoring
Status: Done
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Port synth_permutation_depth_lnn_kms to Rust
7 participants
@Procatv @qiskit-bot @coveralls @alexanderivrii @ShellyGarion @raynelfss @ElePT