Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin setuptools to <72.0.0 to unblock Neko tests #12833

Closed
wants to merge 4 commits into from

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Jul 29, 2024

Summary

See pypa/setuptools#4519

Details and comments

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
constraints.txt Outdated Show resolved Hide resolved
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
@ElePT
Copy link
Contributor Author

ElePT commented Jul 29, 2024

The pin doesn't seem to be enough though, I think I might need to pin setuptools-rust too

@t-imamichi
Copy link
Member

It's still installing setuptools 72

Collecting setuptools
  Downloading setuptools-72.0.0-py3-none-any.whl (2.3 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.3/2.3 MB 50.5 MB/s eta 0:00:00

@ElePT ElePT changed the title Pin setuptools to <0.72.0 to unblock Neko tests Pin setuptools to <72.0.0 to unblock Neko tests Jul 29, 2024
…into pin-setuptools
@ElePT
Copy link
Contributor Author

ElePT commented Jul 29, 2024

This is probably neko's responsibility to fix, although I am still not sure how, so far I have Qiskit/qiskit-neko#47

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10141501468

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 89.754%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.62%
Totals Coverage Status
Change from base Build 10117984709: 0.01%
Covered Lines: 66788
Relevant Lines: 74412

💛 - Coveralls

@ElePT
Copy link
Contributor Author

ElePT commented Jul 29, 2024

Fixed by Qiskit/qiskit-neko#48

@ElePT ElePT closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants