Primitive V1 deprecation follow-up (backport #12824) #12835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Apply tweaks to deprecation messages, docstrings and release notes. * Fix missing backtick * Apply suggestions from Luciano's code review Co-authored-by: Luciano Bello <bel@zurich.ibm.com> * Update qiskit/primitives/statevector_sampler.py Co-authored-by: Luciano Bello <bel@zurich.ibm.com> * Update qiskit/primitives/backend_sampler.py Co-authored-by: Luciano Bello <bel@zurich.ibm.com> * Update qiskit/primitives/primitive_job.py Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> * Update qiskit/primitives/base/base_estimator.py Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> --------- Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> (cherry picked from commit b7d0a97)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
Changelog: None
ElePT
approved these changes
Jul 29, 2024
Pull Request Test Coverage Report for Build 10142527079Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies a series of fixes to the messaging introduced in #11490 to further clarify:
It supersedes #12818 after an offline discussion with @1ucian0.
Details and comments
I am open to suggestions, this is a bit of an intricate message to convey to users.
This is an automatic backport of pull request #12824 done by [Mergify](https://mergify.com).