Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate BackendV2Converter #12840

Merged
merged 8 commits into from
Feb 10, 2025
Merged

Deprecate BackendV2Converter #12840

merged 8 commits into from
Feb 10, 2025

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Jul 29, 2024

With the deprecation of BackendV1, the tool for converting BackendV1 to BackendV2 is now deprecated.

@1ucian0 1ucian0 added this to the 1.4.0 milestone Jul 29, 2024
@1ucian0 1ucian0 requested review from jyu00 and a team as code owners July 29, 2024 13:31
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@1ucian0 1ucian0 mentioned this pull request Jul 29, 2024
Merged
3 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10160207745

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • 40 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.05%) to 89.726%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.39%
crates/qasm2/src/lex.rs 6 91.86%
qiskit/synthesis/two_qubit/xx_decompose/decomposer.py 7 90.84%
crates/qasm2/src/parse.rs 24 95.77%
Totals Coverage Status
Change from base Build 10150038699: -0.05%
Covered Lines: 66933
Relevant Lines: 74597
💛 - Coveralls

@1ucian0 1ucian0 changed the base branch from main to stable/1.4 December 4, 2024 13:59
ElePT
ElePT approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added this pull request to the merge queue Feb 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 10, 2025
@1ucian0
Deprecate BackendV2Converter (#12840)
d34981e 
* deprecate BackendV2Converter

* reno

* silence internal calls

* test.python.compiler.test_transpiler.TestTranspile

* test.python.providers.test_fake_backends

* test.python.compiler.test_transpiler
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@ElePT ElePT added this pull request to the merge queue Feb 10, 2025
Merged via the queue into Qiskit:stable/1.4 with commit 7c72edd Feb 10, 2025
16 checks passed
@ElePT ElePT added the Changelog: Deprecation Include in "Deprecated" section of changelog label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

@jyu00 jyu00 Awaiting requested review from jyu00 jyu00 is a code owner

Assignees

@ElePT ElePT

Labels
Changelog: Deprecation Include in "Deprecated" section of changelog
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@1ucian0 @qiskit-bot @coveralls @ElePT