Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pyproject.toml to run test suite during release builds #12908

Closed
wants to merge 2 commits into from

Conversation

Procatv
Copy link
Contributor

@Procatv Procatv commented Aug 5, 2024

Summary

Fixes #12202

Attempting to resolve this issue by building on previous work as mentioned in previous work in this PR #12551. Tested these changes in my own repo using my changes here: PR in forked repo

Details and comments

Would appreciate feedback on my implementation.

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Aug 5, 2024
@coveralls
Copy link

coveralls commented Aug 5, 2024

Pull Request Test Coverage Report for Build 10269937811

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.003%) to 89.754%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 93.48%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 10222290210: 0.003%
Covered Lines: 67347
Relevant Lines: 75035

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Run test suite during release builds
3 participants