Add get_parameter_by_uuid to CircuitData
#12926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This method receives a `uuid` instance from Python and returns the parameter object identified by said `uuid`.
|
One or more of the following people are relevant to this code:
|
1 task
jakelishman
reviewed
Aug 8, 2024
crates/circuit/src/circuit_data.rs
Outdated
Comment on lines
363
to
369
|
|
||
| pub fn get_parameter_by_uuid(&self, py: Python, uuid: ParameterUuid) -> Option<Py<PyAny>> { | ||
| self.param_table | ||
| .py_parameter_by_uuid(uuid) | ||
| .map(|ob| ob.clone_ref(py)) | ||
| } | ||
|
|
There was a problem hiding this comment.
Does this need to be a pymethod?
Do you think there might any reason to call this without needing the GIL? If so, we could return the Option<&Py<PyAny>> directly and let the caller handle cloning the reference if they need it. I can't think of a huge amount of use for that, though.
There was a problem hiding this comment.
I don't see a need for it to be a pymethod mainly other than keeping it consistent with the counterpart method that allows for you to look for a parameter by name. Now, I could turn it into a rust-native method and then have a pymethod call directly to it, unless we won't use this at all.
Pull Request Test Coverage Report for Build 10308429432Details
💛 - Coveralls |
jakelishman
added
Changelog: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following commits add a method
get_parameter_by_uuidto obtain theParameterobject fromCircuitDatabyuuid.Details and comments
The method retrieves a
Parameterobject from theParameterTablebased on itsuuidwithout exposing any extra data. This could be useful when performing mapping based parameter assignment (as one of the methods from #12913 attempts to do), from rust-space, without having to necessarily pass the aParameterobject to do so.Known issues:
Nothing so far but, if anything is found, leave a comment or review. Thank you!