Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StatePreparation's normalize argument (backport #12988) #12992

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 19, 2024

Summary

Fixes #12984. The definition didn't use the normalized parameters, if the input is synthesized by isometry.


This is an automatic backport of pull request #12988 done by [Mergify](https://mergify.com).

(cherry picked from commit 5963027)
@mergify mergify bot requested a review from a team as a code owner August 19, 2024 19:37
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Aug 19, 2024
@github-actions github-actions bot added this to the 1.2.1 milestone Aug 19, 2024
@mtreinish mtreinish enabled auto-merge August 19, 2024 19:40
@coveralls
Copy link

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 10468451914

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 89.832%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 92.73%
Totals Coverage Status
Change from base Build 10468372678: 0.02%
Covered Lines: 66811
Relevant Lines: 74373

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Aug 20, 2024
Merged via the queue into stable/1.2 with commit 5a246db Aug 20, 2024
17 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-12988 branch August 20, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants