Pending-deprecate library circuits with gate representations #13232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
the
mod: circuit
Cryoris
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
|
One or more of the following people are relevant to this code:
|
which is pending deprecation, but that's fine as GroverOperator will also pend deprecation in the same timeframe for 1.3
Pull Request Test Coverage Report for Build 11688246257Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ElePT
reviewed
Nov 4, 2024
| qc = QuantumCircuit(q, name=self.name) | ||
| for i in range(self.num_qubits): | ||
| for j in range(i + 1, self.num_qubits): | ||
| # if theta was just a single angle, use that, otherwise use the correct index |
There was a problem hiding this comment.
Suggested change
| # if theta was just a single angle, use that, otherwise use the correct index | |
| # if theta is just a single angle, use that, otherwise use the correct index |
| @@ -196,10 +196,12 @@ def __init__(self, *_args, **_kwargs): | |||
| module=r"qiskit\..*", | |||
| message=r".*precision loss in QFT.*", | |||
| ) | |||
| warnings.filterwarnings("ignore", category=PendingDeprecationWarning) | |||
There was a problem hiding this comment.
Do we fail on pending deprecation warnings? I am surprised, I thought we didn't.
There was a problem hiding this comment.
Ah, no we don't but here we have a context that catches all warnings and checks that none are emitted (to check that there is no precision loss) -- so we have to filter out the pending deprecation warning 🙂
| qc = QuantumCircuit(q, name=self.name) | ||
| for i in range(self.num_qubits): | ||
| for j in range(i + 1, self.num_qubits): | ||
| # if theta was just a single angle, use that, otherwise use the correct index | ||
| theta = thetas if isinstance(thetas, ParameterValueType) else thetas[i][j] |
There was a problem hiding this comment.
I believe that it's this line that is currently failing in the unit tests. The error raised is:
TypeError: Subscripted generics cannot be used with class and instance checks
Maybe you can check the shape of the input instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #13046: Library circuits that already have a gate/instruction version are pending-deprecated. These includes:
QFTDiagonalPermutationGMSDetails and comments
As part of this cleanup,
LinearFunctionis streamlined with all other gates by deprecating the customsynthesizemethod in favor of callingdefinition(or compiling the circuit).No reno as all deprecation are only pending.