Single-register arithmetic gates #13371
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no support for parameter expressions for now
some tests miss, some HLS tests fail (maybe Sasha's PR fixes this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #13046: Gates for the single-register arithmetic operations.
Details and comments
I'm opening this PR for people to have a look and for more HLS test cases, but this can probably use some more cleanup. Also all the piecewise gates need an auxiliary qubit, which is currently part of the Gate
num_qubitsbut probably shouldn't be and instead be handled by a synthesis plugin.Since there's already enough for 1.3 I'd suggest we don't include this.