Minor fixes for new adder and multiplier gates classes #13530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added define method to HalfAdder, FullAdder, and ModularAdder classes to allow constructing Operators from quantum circuits containing such adder gates. Fixing plugins related to adder_ripple_v95, the plugins can be used only if n-1 clean ancillas are available. Improved the default adder plugins to choose the best decomposition based on the number of state qubits and the number of ancilla qubits.
|
One or more of the following people are relevant to this code:
|
alexanderivrii
added
the
stable backport potential
Pull Request Test Coverage Report for Build 12293335092Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@Cryoris should we include this for 1.3.1? If so, could you take a look? |
Cryoris
reviewed
Dec 11, 2024
Cryoris
reviewed
Dec 11, 2024
Cryoris
reviewed
Dec 11, 2024
Cryoris
reviewed
Dec 11, 2024
Cryoris
reviewed
Dec 11, 2024
alexanderivrii
changed the title
Cryoris
reviewed
Dec 12, 2024
Cryoris
approved these changes
Dec 12, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
* Fixes to AdderGate classes Added define method to HalfAdder, FullAdder, and ModularAdder classes to allow constructing Operators from quantum circuits containing such adder gates. Fixing plugins related to adder_ripple_v95, the plugins can be used only if n-1 clean ancillas are available. Improved the default adder plugins to choose the best decomposition based on the number of state qubits and the number of ancilla qubits. * Adding tests for the case that adder plugins do not apply * Constructing Operators from circuits with MultiplierGates * release notes * docstring fix * apply suggestions from code review * futher improving tests based on additional review comments (cherry picked from commit b9ea266)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
* Fixes to AdderGate classes Added define method to HalfAdder, FullAdder, and ModularAdder classes to allow constructing Operators from quantum circuits containing such adder gates. Fixing plugins related to adder_ripple_v95, the plugins can be used only if n-1 clean ancillas are available. Improved the default adder plugins to choose the best decomposition based on the number of state qubits and the number of ancilla qubits. * Adding tests for the case that adder plugins do not apply * Constructing Operators from circuits with MultiplierGates * release notes * docstring fix * apply suggestions from code review * futher improving tests based on additional review comments (cherry picked from commit b9ea266) Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds several fixes and improvements for the new adder and multiplier gate classes
FullAdderGate,HalfAdderGate,ModularAdderGateandMultiplierGate.First, it adds the
_definemethod to each of these classes, populatingself.definitionwith some default decomposition of the gate that does not use any ancilla qubits and in particular allows to constructOperators from quantum circuits containing these gates.Second, it fixes the plugins for adder gates based on the "ripple_v95" synthesis function that requires
n-1ancilla qubits. Previously the function could be called with fewer qubits available and the synthesized quantum circuit was not guaranteed to fit into the original quantum circuit leading to internal errors inHighLevelSynthesispass.Third, it adds the default synthesis plugin for
FullAdderGateand improves the default synthesis plugins forHalfAdderGateandModularAdderGateto always choose the best synthesis method depending on the number of ancillas available. Previously, we were getting less optimal circuits for certain small values ofn.Details and comments