Bump PyO3 and rust-numpy to 0.23.x #13577
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bumps the version of pyo3 and rust-numpy used by qiskit to the latest release 0.23. The largest change by volume of code is the deprecation of all the `*_bound()` methods. These are just warnings but they would be fatal to our CI so it needs to be updated. THe larger functional change that required updating the code is the change in the traits around converting to Python objects. This actually found a bug in the target where we were not returning a proper instruction type for standard gates. This also opens up the opportunity to update our hashbrown version to 0.15.x, but we can't do that until the next rustworkx-core release.
mtreinish
added
Changelog: None
mtreinish
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
|
One or more of the following people are relevant to this code:
|
| .get_bound(py) | ||
| .call1((array.to_object(py), py.None(), false))?; | ||
| let unitary_gate = UNITARY_GATE.get_bound(py).call1(( | ||
| <pyo3::Bound<'_, PyArray<Complex<f64>, ndarray::Dim<[usize; 2]>>> as Clone>::clone(&array).into_pyobject(py)?, |
Comment on lines
+179
to
+181
| .into_pyobject(py)? | ||
| .into_any() | ||
| .unbind()) |
There was a problem hiding this comment.
Is this potentially interesting for these cases?
https://pyo3.rs/main/doc/pyo3/conversion/trait.intopyobjectext#method.into_py_any
|
|
||
| impl<'py> IntoPyObject<'py> for &NormalOperation { | ||
| type Target = PyAny; | ||
| type Output = Bound<'py, Self::Target>; |
There was a problem hiding this comment.
From the migration guide, should this be a Borrowed instead?
https://pyo3.rs/v0.23.3/migration.html#intopyobject-manual-implementation
| } | ||
| } | ||
| } | ||
| //impl<'py> IntoPyObject<'py> for Param { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit bumps the version of pyo3 and rust-numpy used by qiskit to the latest release 0.23. The largest change by volume of code is the deprecation of all the
*_bound()methods. These are just warnings but they would be fatal to our CI so it needs to be updated. The larger functional change that required updating the code is the change in the traits around converting to Python objects. This actually found a bug in the target where we were not returning a proper instruction type for standard gates. This also opens up the opportunity to update our hashbrown version to 0.15.x, but we can't do that until the next rustworkx-core release.Details and comments