Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious 0 complex part in Pauli evolution (backport #13643) #13646

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 10, 2025

Summary

Fixes #13642.

Details and comments

This boils down to the fact that, x * (1+0j) = 1.0*x + 0.0*I but pre-1.3 we only multiplied by 1.


This is an automatic backport of pull request #13643 done by [Mergify](https://mergify.com).

Co-authored-by: Elena Peña Tapia <epenatap@gmail.com>
(cherry picked from commit 2476188)
@mergify mergify bot requested review from alexanderivrii, ShellyGarion and a team as code owners January 10, 2025 10:15
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jan 10, 2025
@github-actions github-actions bot added this to the 1.3.2 milestone Jan 10, 2025
@ElePT ElePT enabled auto-merge January 10, 2025 10:21
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12707553253

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.004%) to 88.919%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/synthesis/evolution/suzuki_trotter.py 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 93.18%
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 3 91.73%
qiskit/synthesis/evolution/product_formula.py 5 89.58%
Totals Coverage Status
Change from base Build 12707459091: 0.004%
Covered Lines: 79154
Relevant Lines: 89018

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Jan 10, 2025
Merged via the queue into stable/1.3 with commit bc3c7ed Jan 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants