Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PauliEvolutionGate (using product formulas) for all-identity Pauli terms (backport #13634) #13658

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 14, 2025

Summary

The PauliEvolutionGate, if used with a product formula synthesis (this is the default),
did not correctly handle all-identity terms in the operator:

Details and comments

Some minor corrections to docs are included.


This is an automatic backport of pull request #13634 done by [Mergify](https://mergify.com).

…uli terms (#13634)

* fix PauliEvo for all identities

* fix rustiq

Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>

* fix docs

* regression test 13644

---------

Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>
(cherry picked from commit b98e0d0)
@mergify mergify bot requested review from alexanderivrii, ShellyGarion and a team as code owners January 14, 2025 10:30
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog Rust This PR or issue is related to Rust code in the repository labels Jan 14, 2025
@github-actions github-actions bot added this to the 1.3.2 milestone Jan 14, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12765766650

Details

  • 10 of 12 (83.33%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 88.909%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/circuit/src/operations.rs 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.48%
Totals Coverage Status
Change from base Build 12765466656: -0.001%
Covered Lines: 79155
Relevant Lines: 89029

💛 - Coveralls

@alexanderivrii alexanderivrii added this pull request to the merge queue Jan 14, 2025
Merged via the queue into stable/1.3 with commit fcb0cdd Jan 14, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Rust This PR or issue is related to Rust code in the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants