Fix an error in qasm3 exporter when operating on unitary gates (backport #13633) #13663
+32
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Fix error in qasm3 exporter when operating on unitary gates * Update test/python/qasm3/test_export.py Co-authored-by: Jake Lishman <jake@binhbar.com> * Update releasenotes/notes/fix-qasm-3-unitary-2da190be6ba25bbd.yaml Co-authored-by: Jake Lishman <jake@binhbar.com> --------- Co-authored-by: Jake Lishman <jake@binhbar.com> (cherry picked from commit 087e393)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
the
Changelog: Bugfix
jakelishman
approved these changes
Jan 14, 2025
Pull Request Test Coverage Report for Build 12771464864Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug causing the qasm3 exporter to crash on circuits containing a unitary gate.
Fixes #13362.
Details and comments
The bug results from the
paramsfield of the unitaryoperationbeing handled incorrectly, due to it being a somewhat nonstandard field (as opposed to theparamsfield ofugate, for instance, which is used differently).This problem was already handled in the
qasm2exporter by a call to_qasm2_decompositionin the operation, if present. This PR integrates the same solution in the qasm3 exporter, renaming the method to_qasm_decomposition.This is an automatic backport of pull request #13633 done by [Mergify](https://mergify.com).