Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pulse-related passes #13798

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Remove pulse-related passes #13798

merged 3 commits into from
Feb 7, 2025

Conversation

eliarbel
Copy link
Contributor

@eliarbel eliarbel commented Feb 6, 2025

This commit removes the calibration builder and pulse-gate passes which were deprecated in Qiskit 1.3, together with the pulse package itself. Related unit tests have also been removed.

Details and comments

Part of #13662

This commit removes the calibration builder and pulse-gate passes
which were deprecated in Qiskit 1.3, together with the pulse package
itself. Related unit test have also been removed.
@eliarbel eliarbel requested a review from a team as a code owner February 6, 2025 11:02
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @mtreinish
  • @nkanazawa1989

@eliarbel eliarbel added this to the 2.0.0 milestone Feb 6, 2025
@eliarbel eliarbel added the Changelog: Removal Include in the Removed section of the changelog label Feb 6, 2025
@coveralls
Copy link

coveralls commented Feb 6, 2025

Pull Request Test Coverage Report for Build 13182798192

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 116 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.1%) to 88.45%

Files with Coverage Reduction New Missed Lines %
qiskit/pulse/schedule.py 1 88.42%
qiskit/pulse/instruction_schedule_map.py 1 95.9%
qiskit/transpiler/passes/scheduling/alignments/check_durations.py 1 77.78%
crates/accelerate/src/target_transpiler/nullable_index_map.rs 1 67.17%
crates/qasm2/src/lex.rs 3 91.73%
crates/accelerate/src/two_qubit_decompose.rs 3 91.99%
qiskit/transpiler/preset_passmanagers/generate_preset_pass_manager.py 3 96.2%
qiskit/transpiler/passes/optimization/normalize_rx_angle.py 4 91.49%
crates/accelerate/src/target_transpiler/instruction_properties.rs 5 48.28%
qiskit/providers/backend_compat.py 8 88.42%
Totals Coverage Status
Change from base Build 13181611285: -0.1%
Covered Lines: 78873
Relevant Lines: 89172

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, and it should help unblock the situation in #13793. There are only a couple of lint complaints left that unfortunately github doesn't let me suggest changes for.

Comment on lines +4 to +7
The ``PulseGates``, ``ValidatePulseGates``, ``RXCalibrationBuilder``, ``RZXCalibrationBuilder``,
``RZXCalibrationBuilderNoEcho`` and ``EchoRZXWeylDecomposition`` passes have been removed,
following their deprecation in Qiskit 1.3. These passes depend on and relate to the Pulse
package which is also being removed in Qiskit 2.0.
Copy link
Contributor

@ElePT ElePT Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint is indicating that the inst_map argument in generate_scheduling is no longer used, if we were to remove it (why keep it), the reno should also mention it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the argument is no longer used within generate_scheduling itself indeed (and I addressed the lint warning about that in this PR), but I was thinking about mentioning it in a different reno bullet that removes inst_map from all the other functions (e.g. generate_preset_pass_manager), together possibly with more removals in the transpiler/circuit area rather than here. So if you're OK, I would keep this reno bullet about passes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we don't forget about it, it definitely makes more sense in an independent reno. I sometimes create the reno bullet in one PR and extend it in following ones, but this is a small enough change (and close enough time-wise) that we probably don't need to do that.

ElePT
ElePT previously approved these changes Feb 6, 2025
@ElePT ElePT enabled auto-merge February 6, 2025 14:48
@ElePT ElePT added this pull request to the merge queue Feb 7, 2025
Merged via the queue into Qiskit:main with commit 4ae023a Feb 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants