-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pulse-related passes #13798
Remove pulse-related passes #13798
Conversation
This commit removes the calibration builder and pulse-gate passes which were deprecated in Qiskit 1.3, together with the pulse package itself. Related unit test have also been removed.
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13182798192Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good, and it should help unblock the situation in #13793. There are only a couple of lint complaints left that unfortunately github doesn't let me suggest changes for.
The ``PulseGates``, ``ValidatePulseGates``, ``RXCalibrationBuilder``, ``RZXCalibrationBuilder``, | ||
``RZXCalibrationBuilderNoEcho`` and ``EchoRZXWeylDecomposition`` passes have been removed, | ||
following their deprecation in Qiskit 1.3. These passes depend on and relate to the Pulse | ||
package which is also being removed in Qiskit 2.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint is indicating that the inst_map
argument in generate_scheduling
is no longer used, if we were to remove it (why keep it), the reno should also mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the argument is no longer used within generate_scheduling
itself indeed (and I addressed the lint warning about that in this PR), but I was thinking about mentioning it in a different reno bullet that removes inst_map
from all the other functions (e.g. generate_preset_pass_manager
), together possibly with more removals in the transpiler/circuit area rather than here. So if you're OK, I would keep this reno bullet about passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as we don't forget about it, it definitely makes more sense in an independent reno. I sometimes create the reno bullet in one PR and extend it in following ones, but this is a small enough change (and close enough time-wise) that we probably don't need to do that.
This commit removes the calibration builder and pulse-gate passes which were deprecated in Qiskit 1.3, together with the pulse package itself. Related unit tests have also been removed.
Details and comments
Part of #13662