Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of MCMT in favor of MCMTGate (backport #13584) #13810

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2025

The Multiple-Control-Multiple-Target in qiskit.circuit.library.generalized_gates.MCMT was pending for deprecation in #13150 . This PR moves it to deprecated.


This is an automatic backport of pull request #13584 done by Mergify.

* remove pending deprecations in mcmt

* reno

* testing a regression

(cherry picked from commit 28a33d7)

# Conflicts:
#	test/python/circuit/library/test_mcmt.py
Copy link
Contributor Author

mergify bot commented Feb 7, 2025

Cherry-pick of 28a33d7 has failed:

On branch mergify/bp/stable/1.4/pr-13584
Your branch is up to date with 'origin/stable/1.4'.

You are currently cherry-picking commit 28a33d76.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   qiskit/circuit/library/generalized_gates/mcmt.py
	new file:   releasenotes/notes/followup_13150-5bd0c77248601e1a.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/python/circuit/library/test_mcmt.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Feb 7, 2025
@mergify mergify bot requested a review from a team as a code owner February 7, 2025 16:00
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@github-actions github-actions bot added the Changelog: Deprecation Include in "Deprecated" section of changelog label Feb 7, 2025
@github-actions github-actions bot added this to the 1.4.0 milestone Feb 7, 2025
@1ucian0 1ucian0 removed the conflicts used by mergify when there are conflicts in a port label Feb 12, 2025
1ucian0
1ucian0 previously approved these changes Feb 12, 2025
@1ucian0 1ucian0 enabled auto-merge February 12, 2025 15:49
@1ucian0 1ucian0 added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@ElePT ElePT added this pull request to the merge queue Feb 14, 2025
Merged via the queue into stable/1.4 with commit 4f4de71 Feb 14, 2025
18 of 19 checks passed
@mtreinish mtreinish deleted the mergify/bp/stable/1.4/pr-13584 branch February 19, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants