Consider unit in Delay comparisons
#13816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `unit` field was previously ignored, allowing delays in `dt` units to compare equal to those in `s`. This commit does not add additional on-the-fly unit conversion to the comparison: if the user specified durations in different time multiples, they may have had a reason to consider them non-equal. This could be revisiting after the new system for duration handling lands (i.e. the new functionality for `stretch` and other delayed scheduling).
jakelishman
added
stable backport potential
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13240340536Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
The `unit` field was previously ignored, allowing delays in `dt` units to compare equal to those in `s`. This commit does not add additional on-the-fly unit conversion to the comparison: if the user specified durations in different time multiples, they may have had a reason to consider them non-equal. This could be revisiting after the new system for duration handling lands (i.e. the new functionality for `stretch` and other delayed scheduling). (cherry picked from commit 32eae98)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
The `unit` field was previously ignored, allowing delays in `dt` units to compare equal to those in `s`. This commit does not add additional on-the-fly unit conversion to the comparison: if the user specified durations in different time multiples, they may have had a reason to consider them non-equal. This could be revisiting after the new system for duration handling lands (i.e. the new functionality for `stretch` and other delayed scheduling). (cherry picked from commit 32eae98) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
7 tasks
|
It's probably also worth noting here that the |
|
Kevin: it does - the discrepancy between it and the Python-space version is what prompted #13812. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unitfield was previously ignored, allowing delays indtunits to compare equal to those ins. This commit does not add additional on-the-fly unit conversion to the comparison: if the user specified durations in different time multiples, they may have had a reason to consider them non-equal. This could be revisiting after the new system for duration handling lands (i.e. the new functionality forstretchand other delayed scheduling).Summary
Details and comments
Fix #13812.