Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dt to GenericBackendV2 #13830

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Add dt to GenericBackendV2 #13830

merged 1 commit into from
Feb 12, 2025

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Feb 12, 2025

Summary

This PR allows to configure dt from the GenericBackendV2 init, a useful feature for some scheduling tests. This should have been added from the start but was likely left out as an oversight.

Details and comments

@ElePT ElePT requested review from jyu00 and a team as code owners February 12, 2025 14:21
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@ElePT ElePT added this to the 2.0.0 milestone Feb 12, 2025
@ElePT ElePT added Changelog: New Feature Include in the "Added" section of the changelog mod: fake_provider Related to the fake_provider module and fake backends labels Feb 12, 2025
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this

@mtreinish mtreinish added this pull request to the merge queue Feb 12, 2025
Merged via the queue into Qiskit:main with commit 3eb3538 Feb 12, 2025
18 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13287509449

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.002%) to 88.317%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 2 93.4%
crates/qasm2/src/lex.rs 4 91.98%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 13271264264: 0.002%
Covered Lines: 78804
Relevant Lines: 89229

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: fake_provider Related to the fake_provider module and fake backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants