Fix issue for transpile() around coupling_map kwarg #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transpile call doesn't require a coupling_map kwarg, however the logic around handling the input didn't handle the case when there was no coupling_map and no backend specified. It assumed that if there wasn't a coupling_map input then there was going to be a backend which it could check if there was a coupling_map for (if not it would set it None). However, when backend was also None then this would fail with an AttributeError. This commit corrects the logic so you can call transpile() without a coupling_map in the case a backend is not specified.
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
nonhermitian and
taalexander
as code owners
jaygambetta
previously approved these changes
Mar 2, 2019
ajavadia
reviewed
Mar 3, 2019
1ucian0
previously approved these changes
Mar 8, 2019
ajavadia
previously approved these changes
Mar 10, 2019
1ucian0
approved these changes
Mar 15, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Fix issue for transpile() around coupling_map kwarg The transpile call doesn't require a coupling_map kwarg, however the logic around handling the input didn't handle the case when there was no coupling_map and no backend specified. It assumed that if there wasn't a coupling_map input then there was going to be a backend which it could check if there was a coupling_map for (if not it would set it None). However, when backend was also None then this would fail with an AttributeError. This commit corrects the logic so you can call transpile() without a coupling_map in the case a backend is not specified. * Fix lint * Disable method name length enforcement for test code * regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The transpile call doesn't require a coupling_map kwarg, however the
logic around handling the input didn't handle the case when there was no
coupling_map and no backend specified. It assumed that if there wasn't a
coupling_map input then there was going to be a backend which it could
check if there was a coupling_map for (if not it would set it None).
However, when backend was also None then this would fail with an
AttributeError. This commit corrects the logic so you can call
transpile() without a coupling_map in the case a backend is not
specified.
Details and comments