Add dissasembler to dissassemble a compiled qobj #2137
Merged
+205
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new dissassembler module that has a single dissasemble function. This is used to take an input qobj and return the circuits, run_config, and user headers which are stored in it. Fixes Qiskit#1952
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
nonhermitian and
taalexander
as code owners
|
Still WIP until I add tests covering this |
|
The tests will start passing when #2138 is merged |
mtreinish
changed the title
kdk
reviewed
Apr 18, 2019
This rule is completely broken and often just returns false postives. The latest example can be found here: https://travis-ci.com/Qiskit/qiskit-terra/jobs/194288168 We can just rely on python to catch a cyclic import issues, because it'll raise an error if it's not resolvable.
ajavadia
reviewed
Apr 22, 2019
ajavadia
approved these changes
Apr 23, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Add dissasembler to dissassemble a compiled qobj This commit adds a new dissassembler module that has a single dissasemble function. This is used to take an input qobj and return the circuits, run_config, and user headers which are stored in it. Fixes Qiskit#1952 * Add tests * Add header asserts * Fix lint * Fix tests * Fix lint * Deprecate qobj_to_circuits * Fix typos * Disable cyclic-import pylint rule This rule is completely broken and often just returns false postives. The latest example can be found here: https://travis-ci.com/Qiskit/qiskit-terra/jobs/194288168 We can just rely on python to catch a cyclic import issues, because it'll raise an error if it's not resolvable. * Revert "Disable cyclic-import pylint rule" This reverts commit 7e614ec. * Update import paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds a new dissassembler module that has a single
dissasemble function. This is used to take an input qobj and return the
circuits, run_config, and user headers which are stored in it.
Details and comments
Fixes #1952