Bump lint jobs to latest stable python version #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python version used for pylint can effect results returned, pylint is very sensitive to the environment it's run in. Running on python 3.5 which is the oldest supported python version masks issues on newer python versions. For example, if you have python 3.7 installed locally lint will always fail becaues of changes to the stdlib. This starts to become more of an issue as a particular python version ages, since the user and contributor base moves to newer versions of python. This commit changes the version of pylint we run in CI to 3.7 to tests the leading edge instead of the trailing so we keep our pylint testing up to date with the python versions we support. Related to Qiskit#3127 and Qiskit#1179
The abc.ABCMeta class defition added a **kwargs to the __new__ method definition in python 3.6. This breaks the linter because the qiskit.pulse.commands.command.MetaCount subclass function signature differs from stdlib on newer python versions. This works around this by adding a throwaway kwargs argument to the signature so that we pass pylint's blind pedantry when running on newer python versions, but still work with python 3.5.
ajavadia
approved these changes
Oct 9, 2019
taalexander
approved these changes
Oct 9, 2019
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* Bump lint jobs to latest stable python version The python version used for pylint can effect results returned, pylint is very sensitive to the environment it's run in. Running on python 3.5 which is the oldest supported python version masks issues on newer python versions. For example, if you have python 3.7 installed locally lint will always fail becaues of changes to the stdlib. This starts to become more of an issue as a particular python version ages, since the user and contributor base moves to newer versions of python. This commit changes the version of pylint we run in CI to 3.7 to tests the leading edge instead of the trailing so we keep our pylint testing up to date with the python versions we support. Related to Qiskit#3127 and Qiskit#1179 * Add **kwargs to avoid linter error The abc.ABCMeta class defition added a **kwargs to the __new__ method definition in python 3.6. This breaks the linter because the qiskit.pulse.commands.command.MetaCount subclass function signature differs from stdlib on newer python versions. This works around this by adding a throwaway kwargs argument to the signature so that we pass pylint's blind pedantry when running on newer python versions, but still work with python 3.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The python version used for pylint can effect results returned, pylint
is very sensitive to the environment it's run in. Running on python 3.5
which is the oldest supported python version masks issues on newer
python versions. For example, if you have python 3.7 installed locally
lint will always fail becaues of changes to the stdlib. This starts to
become more of an issue as a particular python version ages, since the
user and contributor base moves to newer versions of python. This commit
changes the version of pylint we run in CI to 3.7 to tests the leading
edge instead of the trailing so we keep our pylint testing up to date
with the python versions we support.
Details and comments
Related to #3127 and #1179