Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Pass qobj to remote backends. Implement qobj validation. #326

Closed
wants to merge 4 commits into from

Conversation

ewinston
Copy link
Contributor

@ewinston ewinston commented Mar 8, 2018

Qobj validation occurs against qobj-core and qobj-generic schemas.

New project directory, "qobj" introduced where schemas live. Future Qobj class
can go here.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Erick Winston and others added 3 commits March 8, 2018 13:02
Qobj validation occurs against qobj-core and qobj-generic schemas.

New project directory, "qobj" introduced where schemas live. Future Qobj class
can go here.
@ajavadia
Copy link
Member

Hey Erick, while you change lines 69-77 of qxremote.py to take out compiled_circuit_qasm, could you please make sure the circuit name is also sent to the API? Right now this line does not put the circuit name in the job.
https://github.com/ewinston/qiskit-sdk-py/blob/69fe67f6c67d6fb9e8351f3269d732771811f5f4/qiskit/backends/_qxremote.py#L75

So then when we query the API for a particular job id, we will be able to see the user-defined circuit names too.

In the qobj core schema, only ["circuits"]["compiled_circuit"] is mandatory, and ["circuits"]["name"] is optional. But it would be good to have it. It was requested on the QISKit slack channel.

@ewinston
Copy link
Contributor Author

Hi Ali, yes I was expecting much of the run code in qxremote to change once the api for submitting qobj has solidified.

@ewinston
Copy link
Contributor Author

ewinston commented May 1, 2018

The issue has moved to #415

@ewinston ewinston closed this May 1, 2018
@ewinston ewinston deleted the qobj-qx branch June 9, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants