[WIP] Simulator backends refactor #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
- parameters ‘calibration_error’, ‘detuning_error’, ‘zz_error’ for CX and X90 gates are now converted to U_error matrices in python before being passed to simulator - fixed incorrect matrix used for CX calibration errors - added check in C++ code that U_error is unitary - added python unit tests to test U_error building matrices - fixed directory change in makefile Updated modified JSON library to version 3.1.1 Modification is so that pretty printing of arrays doesn’t add new lines.
- Encapsulated multi-partite qubit state vector updates in a QubitVector class - Added TensorIndex class used for indexing in the QubitVector class. - Reworked ideal_backend and qubit_backend to use QubitVector methods - merged sampleshots_engine into vector_engine - removed ability to display final and saved quantum states - added “snapshot” instruction and added ability to display snapshots of quantum state
- renamed qiskit backend - renamed qiskit_simulator -> qasm_simulator_cpp - Started modifying CHANGELOG for v0.5
Fixed missing parentheses for some snapshot statements Added auto check to makefile for GCC7 compiler on macOS
…ings, added string simulator input/output
…king of simulator
…e to fix old config key names
…, allowed sample shots to compute probability vector in place to save memory
…thon compiler warning
* new dependencies target (make depend) for the qasm-simulator-cpp (cherry picked from commit 3b25390) * changed to executable and bug fix (cherry picked from commit ce8be89) * assume yes for automatic pkg install (cherry picked from commit 2cd7607) * -march not supported on ppc64le. Use -mcpu instead (cherry picked from commit 7cdab8f) * bugfix (cherry picked from commit 831692e)
chriseclectic
force-pushed
the
cpp-simulator-refactor
branch
from
848107b to
2ad63ba
Compare
- added default qubit, clbit values to qobj circuit header - added virtual destructors to C++ base classes
fix sympy simulators. fix backend methods.
Cpp simulator refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP on refactoring simulator backends (related to issues #281, and #314). This is a rebased version of WIP #319 to clean up the commit history and merge with recent commits to master.
Types of changes
Current changes
tensor_index.hpp) for multi-partite qubit vector indexingqubit_vector.hpp) for multi-partite qubit vector algebraQubitVectorclass and methods instead ofstd::vector.savecommand (usesnapshotinstead)snapshotinstead)