Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up examples and README #357

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Clean up examples and README #357

merged 2 commits into from
Mar 22, 2018

Conversation

ajavadia
Copy link
Member

@ajavadia ajavadia commented Mar 22, 2018

This is a cleanup of some of the examples and the README given the recent issues (#344, #354, Slack messages).

  • The hello_quantum example in the README is now more concise, and uses the QISKit interfaces better (instead of using QuantumProgram for everything).

  • Increased timeout to 300 for the hello_quantum example.

  • Removed the relative imports in all examples, and replaced with a note.

  • General cleanup of README.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diego-plan9
Copy link
Member

Thanks @ajavadia - removing the sys.path mangling and also taking the chance to start the moving away from QuantumProgram is awesome! 👍

@diego-plan9 diego-plan9 merged commit e49ab48 into Qiskit:master Mar 22, 2018
@ajavadia ajavadia deleted the hello branch March 24, 2018 17:55
ajavadia added a commit to ajavadia/qiskit that referenced this pull request Mar 26, 2018
* removed relative import warning from examples

* Cleaner examples
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
* removed relative import warning from examples

* Cleaner examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants