Fix bug where lo units were not being properly converted #3597

taalexander · 2019-12-11T04:15:58Z

Summary

Closes #3595, #3596. Fixes a bug where lo units are not being properly converted, nor were they being accepted in Hz by assemble/execute and schedule_los.

Details and comments

… Hz.

lcapelluto · 2019-12-16T15:11:15Z

qiskit/providers/models/backendconfiguration.py

@@ -325,13 +325,20 @@ def __init__(self,
        self.n_uchannels = n_uchannels
        self.u_channel_lo = u_channel_lo
        self.meas_levels = meas_levels
-        self.qubit_lo_range = qubit_lo_range
-        self.meas_lo_range = meas_lo_range
+        self.qubit_lo_range = [[range[0] * 1e9, range[1] * 1e9] for range in qubit_lo_range]


it's a little confusing seeing range as a variable and not the built in range method

agreed, should be different name

@taalexander so can you fix it. also lines 329 and 339. otherwise LGTM.

yes, I will return to this soon.

Fixed in 555f727

lcapelluto · 2019-12-16T15:12:19Z

With this PR, assemble and execute will take frequency in terms of Hz, and output a qobj still in GHz, correct?

taalexander

yes

…o-units

taalexander · 2019-12-27T15:20:39Z

This should be good to go now.

qiskit/compiler/assemble.py

lcapelluto · 2020-01-06T15:43:21Z

qiskit/compiler/assemble.py

@@ -77,24 +77,24 @@ def assemble(experiments,
            Random seed to control sampling, for when backend is a simulator

        qubit_lo_freq (list):
-            List of default qubit LO frequencies. Will be overridden by
+            List of default qubit lo frequencies in Hz. Will be overridden by


Why lowercase?

qiskit/compiler/assemble.py

Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com>

* Fix backend config where lo ranges were not adjusted to Hz. * Fix bug where assemble/execute accepted parameters in GHz rather than Hz. * linting * Documentation fixes for Hz. * Add channel bandwidth. * bug fix with kwarg pop. * Missing None in kwargs pop. * linting. * Fix range in list comprehension for lo ranges in backend configuration. * Update qiskit/compiler/assemble.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/compiler/assemble.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * lo to LO in docstrings. Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> (cherry picked from commit a187d83)

* Fix backend config where lo ranges were not adjusted to Hz. * Fix bug where assemble/execute accepted parameters in GHz rather than Hz. * linting * Documentation fixes for Hz. * Add channel bandwidth. * bug fix with kwarg pop. * Missing None in kwargs pop. * linting. * Fix range in list comprehension for lo ranges in backend configuration. * Update qiskit/compiler/assemble.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/compiler/assemble.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * lo to LO in docstrings. Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> (cherry picked from commit a187d83) Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com>

* Fix backend config where lo ranges were not adjusted to Hz. * Fix bug where assemble/execute accepted parameters in GHz rather than Hz. * linting * Documentation fixes for Hz. * Add channel bandwidth. * bug fix with kwarg pop. * Missing None in kwargs pop. * linting. * Fix range in list comprehension for lo ranges in backend configuration. * Update qiskit/compiler/assemble.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/compiler/assemble.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * lo to LO in docstrings. Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com>

* Fix backend config where lo ranges were not adjusted to Hz. * Fix bug where assemble/execute accepted parameters in GHz rather than Hz. * linting * Documentation fixes for Hz. * Add channel bandwidth. * bug fix with kwarg pop. * Missing None in kwargs pop. * linting. * Fix range in list comprehension for lo ranges in backend configuration. * Update qiskit/compiler/assemble.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * Update qiskit/compiler/assemble.py Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com> * lo to LO in docstrings. Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> (cherry picked from commit a187d83) # Conflicts: # qiskit/assembler/assemble_schedules.py # qiskit/compiler/assemble.py # qiskit/execute.py # qiskit/providers/models/backendconfiguration.py # test/python/compiler/test_assembler.py

taalexander added 2 commits December 10, 2019 23:12

Fix backend config where lo ranges were not adjusted to Hz.

7e43c82

Fix bug where assemble/execute accepted parameters in GHz rather than…

f1f05eb

… Hz.

taalexander added bug Something isn't working priority: high labels Dec 11, 2019

taalexander requested review from 1ucian0, ajavadia, diego-plan9, kdk and mtreinish as code owners December 11, 2019 04:15

linting

21882a7

taalexander added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Dec 11, 2019

taalexander added 5 commits December 10, 2019 23:57

Documentation fixes for Hz.

eb84e89

Add channel bandwidth.

d74eb69

bug fix with kwarg pop.

471775e

Missing None in kwargs pop.

da81746

linting.

4c25da2

mtreinish added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Dec 12, 2019

lcapelluto reviewed Dec 16, 2019

View reviewed changes

taalexander commented Dec 16, 2019

View reviewed changes

taalexander added 2 commits December 27, 2019 11:11

Merge remote-tracking branch 'upstream/master' into issue-3595-3596-l…

e00b6c6

…o-units

Fix range in list comprehension for lo ranges in backend configuration.

555f727

Merge branch 'master' into issue-3595-3596-lo-units

0ea3256

lcapelluto reviewed Jan 6, 2020

View reviewed changes

qiskit/compiler/assemble.py Outdated Show resolved Hide resolved

lcapelluto reviewed Jan 6, 2020

View reviewed changes

qiskit/compiler/assemble.py Outdated Show resolved Hide resolved

lcapelluto reviewed Jan 6, 2020

View reviewed changes

qiskit/compiler/assemble.py Show resolved Hide resolved

lcapelluto reviewed Jan 6, 2020

View reviewed changes

qiskit/compiler/assemble.py Outdated Show resolved Hide resolved

taalexander and others added 3 commits January 6, 2020 11:11

Update qiskit/compiler/assemble.py

14cb6c8

Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com>

Update qiskit/compiler/assemble.py

b0a77f4

Co-Authored-By: Lauren Capelluto <laurencapelluto@gmail.com>

lo to LO in docstrings.

b554c3c

lcapelluto approved these changes Jan 6, 2020

View reviewed changes

Merge branch 'master' into issue-3595-3596-lo-units

ac49ef4

mtreinish approved these changes Jan 6, 2020

View reviewed changes

mtreinish added the automerge label Jan 6, 2020

kdk approved these changes Jan 6, 2020

View reviewed changes

mergify bot merged commit a187d83 into Qiskit:master Jan 6, 2020

lcapelluto mentioned this pull request Jan 6, 2020

Change rep_time unit to s #3612

Merged

mtreinish mentioned this pull request Jan 7, 2020

[Stable] Fix bug where lo units were not being properly converted (#3597) #3696

Merged

eembees mentioned this pull request Jan 9, 2020

Convert Hamiltonian variables to Hz #3599

Closed

willhbang mentioned this pull request Feb 16, 2020

Execute/Assembly still expect qubit/measurement lo frequencies in Hz #3596

Closed

1ucian0 added the mod: pulse Related to the Pulse module label Jan 15, 2021

mergify bot mentioned this pull request Jan 15, 2021

Fix bug where lo units were not being properly converted (bp #3597) #5633

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug where lo units were not being properly converted #3597

Fix bug where lo units were not being properly converted #3597

taalexander commented Dec 11, 2019

lcapelluto Dec 16, 2019

taalexander Dec 16, 2019 •

edited

Loading

ajavadia Dec 24, 2019 •

edited

Loading

taalexander Dec 27, 2019

taalexander Dec 27, 2019

lcapelluto commented Dec 16, 2019

taalexander left a comment

taalexander commented Dec 27, 2019

lcapelluto Jan 6, 2020

Fix bug where lo units were not being properly converted #3597

Fix bug where lo units were not being properly converted #3597

Conversation

taalexander commented Dec 11, 2019

Summary

Details and comments

lcapelluto Dec 16, 2019

Choose a reason for hiding this comment

taalexander Dec 16, 2019 • edited Loading

Choose a reason for hiding this comment

ajavadia Dec 24, 2019 • edited Loading

Choose a reason for hiding this comment

taalexander Dec 27, 2019

Choose a reason for hiding this comment

taalexander Dec 27, 2019

Choose a reason for hiding this comment

lcapelluto commented Dec 16, 2019

taalexander left a comment

Choose a reason for hiding this comment

taalexander commented Dec 27, 2019

lcapelluto Jan 6, 2020

Choose a reason for hiding this comment

taalexander Dec 16, 2019 •

edited

Loading

ajavadia Dec 24, 2019 •

edited

Loading