-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add average_gate_fidelity
, gate_error
, and modify process_fidelity
functions
#3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajavadia
reviewed
Dec 31, 2019
can you add a couple tests and a release note |
ajavadia
previously approved these changes
Dec 31, 2019
* Added ``average_gate_fidelity`` and ``gate_error`` function for operators * ``process_fidelity`` requires target channel to be Operator or None if target is None F computed wrt identity operator. * Deprecated ``require_cptp`` kwarg for ``process_fidelity`` * Added ``require_cp`` and ``require_tp`` kwargs for ``process_fidelity`` with defaults True and False
4b5de3a
to
9eadea5
Compare
ajavadia
approved these changes
Jan 21, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…idelity`` functions (Qiskit#3660) * add average_gate_fidelity, gate_error, and modify process_fidelity * Added ``average_gate_fidelity`` and ``gate_error`` function for operators * ``process_fidelity`` requires target channel to be Operator or None if target is None F computed wrt identity operator. * Deprecated ``require_cptp`` kwarg for ``process_fidelity`` * Added ``require_cp`` and ``require_tp`` kwargs for ``process_fidelity`` with defaults True and False * typo * update documentation * add tests * add release note * linting Co-authored-by: Ali Javadi-Abhari <ajavadia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
average_gate_fidelity
andgate_error
function for operatorsprocess_fidelity
to requires target channel to be anOperator
orNone
if target is None F computed wrt identity operator.
require_cptp
kwarg forprocess_fidelity
require_cp
andrequire_tp
kwargs forprocess_fidelity
with defaults True and False
Details and comments