Allow for circuit measure methods to return a new circuit with inplace kwarg #3755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonhermitian
requested review from
1ucian0,
ajavadia,
ewinston,
kdk and
mtreinish
as code owners
|
can you do something similar for |
nonhermitian
changed the title
kdk
approved these changes
Jan 30, 2020
kdk
added
automerge
Changelog: API Change
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…e kwarg (Qiskit#3755) * all inplace kwarg to measure_all * fix style * fix lint * Update quantumcircuit.py * add inplace to other measure methods * add release note Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Often one wants to add or remove measurements to a circuit without modifying the current one in place. As such, I modified
QuantumCircuit.measure_all(),.measure_active()and.remove_final_measurements()to take the bool kwarginplacethat leaves the original circuit untouched, and returns a modified one wheninplace=False(default is True).Details and comments