deepcopy(Instruction) to use Instruction.copy. #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdk
requested review from
1ucian0,
ajavadia,
ewinston and
mtreinish
as code owners
mtreinish
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
LGTM given our offline discussion. I do have some concerns that this could break end user expectations (because we're not really returning a true deepcopy). But it does address the performance regression, and at least as far as our testing goes doesn't break any behavior we've encoded in the tests. We'll probably address this issue more thoroughly as part of #3800 in the future.
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To partially address the regression introduced in #3773 and the issue raised in #3800 , updates
deepcopy(Instruction)to returnInstruction.copy()which shallow copies the instruction instance and itsparams.Details and comments