Command/Inst refactor: Acquire (and Kernel, Discriminator) #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int to the new one. Deprecate AcquireInstruction and make it return an Acquire instead
lcapelluto
changed the title
lcapelluto
force-pushed
the
issue-3750-acquire-instruction
branch
2 times, most recently
from
5ae572a to
c284476
Compare
lcapelluto
requested review from
DanPuzzuoli,
eggerdj and
nkanazawa1989
as code owners
…cqurie. Fix up some more tests. Fill in pulse_instructions converter for Acquire
lcapelluto
requested review from
diego-plan9,
jyu00,
kdk and
mtreinish
as code owners
Improve description of Acquire Co-Authored-By: Thomas Alexander <thomasalexander2718@gmail.com>
…o/qiskit-terra into issue-3750-acquire-instruction
…a test to also match
…o/qiskit-terra into issue-3750-acquire-instruction
taalexander
previously requested changes
Mar 18, 2020
taalexander
approved these changes
Mar 18, 2020
mtreinish
reviewed
Mar 18, 2020
releasenotes/notes/unify-instructions-and-commands-aaa6d8724b8a29d3.yaml
Outdated
Show resolved
Hide resolved
taalexander
previously approved these changes
Mar 18, 2020
…o/qiskit-terra into issue-3750-acquire-instruction
taalexander
previously approved these changes
Mar 18, 2020
mtreinish
reviewed
Mar 18, 2020
releasenotes/notes/unify-instructions-and-commands-aaa6d8724b8a29d3.yaml
Outdated
Show resolved
Hide resolved
…a29d3.yaml Co-Authored-By: Matthew Treinish <mtreinish@kortar.org>
taalexander
approved these changes
Mar 18, 2020
mtreinish
approved these changes
Mar 18, 2020
lcapelluto
added
the
Changelog: API Change
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* Make new Acquire instruction and update path to Acquire command to point to the new one. Deprecate AcquireInstruction and make it return an Acquire instead * Fix some style and continue implementation * Fill in docs and fix tests * Fill in __repr__ and __eq__ as necessary for Kernel, Discriminator, Acqurie. Fix up some more tests. Fill in pulse_instructions converter for Acquire * Style fixes * Fix bug missing inclusion of Acquire type along with AcquireInstruction * Fixup some kernel instantiation in pulse instructions converter * Fixup style * Try to fix the docs build * Update qiskit/pulse/instructions/acquire.py Improve description of Acquire Co-Authored-By: Thomas Alexander <thomasalexander2718@gmail.com> * Respond to review * Update repr for Kernel and Discriminator to reflect **params. Update a test to also match * style * Complete release note * Complete reno note (was missing one line) * discriminator and kernel shouldn't be treated as instruction operands * Add link in releasenote * Update releasenotes/notes/unify-instructions-and-commands-aaa6d8724b8a29d3.yaml Co-Authored-By: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 5/7 for issue #3750
Make new Acquire instruction and update path to Acquire command to point to the new one. Deprecate AcquireInstruction and make it return an Acquire instead
Details and comments
This is going to look so much nicer after the deprecation period for the multiple layers of changes that have been made 😄