Adds ability to set ctrl_state on standard gates #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewinston
requested review from
1ucian0,
ajavadia,
kdk and
mtreinish
as code owners
1ucian0
added
the
Changelog: Bugfix
1ucian0
approved these changes
Apr 24, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* ctrl_state for Rotation gates * docstring * extending the test to other gates * lint * add strl state setting to gate init * add ctrl_state to standard gates * move compute_control_matrix * linting * remove comment * linting * black and add test * silent deprecation * deprecation gates * some ddt * TestSingleControlledRotationGates * linting * merge master * fix controlled cx gate * linting * some missing cases with C*X * all the logic to MCXGate * ups * added release notes * minor release notes edit Co-authored-by: Luciano Bello <luciano.bello@ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the ability to set
ctrl_stateon standard controlled gates. This change resolves a bug when checking for gate equality since previously setting ctrl_state would potentially not return a gate of the same class. Also, tests were added to check ctrl_state setting on all standard gates.fixes #4138
Details and comment
Co-authored-by: lbello@gmail.com