Instruction.is_parameterized to return False when fully bound. #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes a failure of TestKAKOverOptim.test_cu1_optimization after switching to BasisTranslator. For CU1, the Unroller will generate U1Gate(pi/2), ..., but the BasisTranslator will generate a (still valid) U1Gate(ParameterExpression(pi/2)).
kdk
requested review from
1ucian0,
ajavadia,
ewinston and
mtreinish
as code owners
ajavadia
approved these changes
Apr 23, 2020
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…t#4198) This causes a failure of TestKAKOverOptim.test_cu1_optimization after switching to BasisTranslator. For CU1, the Unroller will generate U1Gate(pi/2), ..., but the BasisTranslator will generate a (still valid) U1Gate(ParameterExpression(pi/2)). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes a failure of TestKAKOverOptim.test_cu1_optimization after
switching to BasisTranslator. For CU1, the Unroller will generate
U1Gate(pi/2), ..., but the BasisTranslator will generate a (still
valid) U1Gate(ParameterExpression(pi/2)).
Summary
Details and comments