pi_check in qasm and truncate floats #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonhermitian
requested review from
1ucian0,
ajavadia,
ewinston,
jaygambetta,
kdk,
maddy-tod and
mtreinish
as code owners
jaygambetta
previously approved these changes
Apr 27, 2020
|
can you add a test that the qasm produced by this is parsable. |
ajavadia
approved these changes
Apr 27, 2020
|
good to go after it passes |
|
Hold on doing sqrt(2) as well |
|
@nonhermitian that was just as a suggestion in my approval. It could be another pr as there might be a few irrational numbers we want to use (don't do them all but quantum does use a few) |
|
Ok, I hold off for another day. |
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* pi_check in qasm and truncate floats * lint * Update latex.py * Update matplotlib.py * Update text.py * add round trip qasm test Co-authored-by: Jay Gambetta <jay.gambetta@us.ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #4272
Does what the title says.
Details and comments