Global MS gate in circuit library #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajavadia
requested review from
1ucian0,
ewinston,
jaygambetta,
kdk and
mtreinish
as code owners
jaygambetta
reviewed
Apr 28, 2020
jaygambetta
approved these changes
Apr 28, 2020
jaygambetta
previously approved these changes
Apr 28, 2020
jaygambetta
previously approved these changes
Apr 29, 2020
ajavadia
force-pushed
the
circuit-library-ms
branch
from
eb61d44 to
0bbe081
Compare
ajavadia
force-pushed
the
circuit-library-ms
branch
from
3924501 to
f08cc43
Compare
|
@jaygambetta citations, equation and test added. I called it GMS (global molmer sorensen) after ref [2]. |
jaygambetta
approved these changes
Apr 29, 2020
mtreinish
added
the
Changelog: New Feature
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* circuit library ms * add reference and equation * take angle matrix. add test * lint Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just creates a new entry under generalized_gates. does not deprecate old one yet.