Timeslot error fix and tests #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taalexander
requested review from
DanPuzzuoli,
eggerdj and
nkanazawa1989
as code owners
taalexander
force-pushed
the
issue-4334-timeslot-error-fix
branch
from
9e14769 to
ab6a3be
Compare
taalexander
force-pushed
the
issue-4334-timeslot-error-fix
branch
from
ab6a3be to
469e583
Compare
lcapelluto
previously approved these changes
Apr 29, 2020
lcapelluto
previously approved these changes
Apr 29, 2020
lcapelluto
approved these changes
Apr 30, 2020
lcapelluto
added
the
Changelog: Bugfix
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* Add test cases for issues with timeslots.' * Fix small bug in timeslot insertion finder. * Fixed another error in the code path. * Remove accidental comment. * Add docstring to new tests * Fix another small timeslot bug. Co-authored-by: Ali Javadi-Abhari <ajavadia@users.noreply.github.com> Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4334. Fixes small bug in new timeslot implementation and adds new tests to verify the expected behavior.
Details and comments